Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul branch protection rules #1118

Closed
tsalo opened this issue Aug 7, 2024 · 2 comments · Fixed by #1135
Closed

Overhaul branch protection rules #1118

tsalo opened this issue Aug 7, 2024 · 2 comments · Fixed by #1135
Labels
community issues related to building a healthy community maintenance issues related to versioning, dependencies, and other related elements

Comments

@tsalo
Copy link
Member

tsalo commented Aug 7, 2024

Summary

I think we should drop the number of required approvals from 2 to 1 and we should stop dismissing reviews as stale on new commits. I think we can trust contributors to request new reviews if their changes invalidate old reviews.

@tsalo tsalo added community issues related to building a healthy community maintenance issues related to versioning, dependencies, and other related elements labels Aug 7, 2024
@handwerkerd
Copy link
Member

I agree. I could see requiring only 1 review, but adding to the contributors guide that 2 reviews are expected for PRs that include substantive functionality or code changes. We can trust contributors to self-identify which ones those are.

@tsalo
Copy link
Member Author

tsalo commented Sep 19, 2024

From today's call, everyone's good with this. I'll handle the documentation changes and under-the-hood settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community issues related to building a healthy community maintenance issues related to versioning, dependencies, and other related elements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants