-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fMRIPrep requirements and T2SMap interface to 0.0.9 #540
Comments
How does everyone feel about the proposed changes here? |
I have no concerns - in fact, more descriptive names can only be beneficial (other than breaking scripts). Gets my thumbs up. |
On a related note, t2smap_workflow does not use Also, our T2* maps will now be in seconds (#525). @emdupre do you think that will cause problems for fMRIPrep's |
The map being in seconds won't cause any isues as far as I can see. Setting an As a light tangent: I think the decision was to remove Just to be clear, though: we still create a T2StarMap and optimal combination in fMRIPrep even if |
Summary
Changes in 0.0.9 will break fMRIPrep's T2SMap interface (particularly #416).
Next Steps
t2sv.nii
-->T2StarMap.nii.gz
(given the BEP001 suffix)s0v.nii
-->S0Map.nii.gz
(given the BEP001 suffix)ts_OC.nii
-->desc-optcom_bold.nii.gz
(maybe)t2star_adaptive_map
ands0_adaptive_map
fromfmriprep.interfaces.multiecho.T2SMapOutputSpec
. These aren't the adaptive maps actually- they're the "full" ones.The text was updated successfully, but these errors were encountered: