Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose conservatively-masked data, but denoise liberally-masked data #685

Closed
tsalo opened this issue Feb 19, 2021 · 0 comments · Fixed by #736
Closed

Decompose conservatively-masked data, but denoise liberally-masked data #685

tsalo opened this issue Feb 19, 2021 · 0 comments · Fixed by #736
Labels
decomposition issues related to decomposition methods effort: medium Theoretically <40h total work enhancement issues describing possible enhancements to the project impact: high Enhancement or functionality improvement that will affect most users priority: high issues that would be really helpful if they were fixed already TE-dependence issues related to TE dependence metrics and component selection

Comments

@tsalo
Copy link
Member

tsalo commented Feb 19, 2021

Summary

Per today's call, we should try to adapt the denoising workflow so that the decision tree is applied to the conservatively-masked combined data (i.e., an adaptive mask threshold of 3), but a liberally-masked version is what's denoised (i.e., an adaptive mask threshold of 1).

Additional Detail

This should address concerns about coverage brought up in #600 and #680.

Next Steps

  1. Estimate T2*/S0 with liberal threshold.
  2. Perform optimal combination with both thresholds.
  3. Feed conservatively-masked version into the decomposition and decision tree portions of the tedana workflow.
  4. Feed liberally-masked version into the actual denoising portion of the workflow.
  5. Output both versions of the combined data, as well as T2* and S0 maps.
@tsalo tsalo added enhancement issues describing possible enhancements to the project TE-dependence issues related to TE dependence metrics and component selection decomposition issues related to decomposition methods labels Feb 19, 2021
@tsalo tsalo added effort: medium Theoretically <40h total work impact: high Enhancement or functionality improvement that will affect most users priority: high issues that would be really helpful if they were fixed already labels Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decomposition issues related to decomposition methods effort: medium Theoretically <40h total work enhancement issues describing possible enhancements to the project impact: high Enhancement or functionality improvement that will affect most users priority: high issues that would be really helpful if they were fixed already TE-dependence issues related to TE dependence metrics and component selection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant