Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating minimum required python package versions (nilearn) #761

Closed
handwerkerd opened this issue Jul 19, 2021 · 2 comments · Fixed by #763
Closed

Updating minimum required python package versions (nilearn) #761

handwerkerd opened this issue Jul 19, 2021 · 2 comments · Fixed by #763
Assignees
Labels
documentation issues related to improving documentation for the project effort: low Theoretically less than a day's work impact: low Improving code/documentation cleanliness/clarity, not function

Comments

@handwerkerd
Copy link
Member

Summary

I just found out that nilearn added carpet plots in version 0.7 (I was still on 0.6). We currently don't have any minimum version requirement for nilearn, so we should add 0.7.

Additional Detail

Checking into this, I also noticed nilearn is soon phasing out nibabel 2.0 support. I don't know if we should already restrict the minimum version, but we should probably keep track of this. nilearn also lists it's minimum reqs at numpy 1.16, SciPy 1.2, scikit-learn 0.21, nibabel 2.5, & pandas 0.24. Since we are using a bunch of these through nilearn, we might want to consider changing some of those versions to our new minimums.

Next Steps

  • Use this as an excuse to check if there are any other version minimums that are also out-of-date. Decide which version minimums to change now.

Change the versions listed in:

  • README.md
  • docs/installation.rst
  • tedana/info.py
  • Anywhere else?
@handwerkerd handwerkerd added documentation issues related to improving documentation for the project effort: low Theoretically less than a day's work impact: low Improving code/documentation cleanliness/clarity, not function labels Jul 19, 2021
@handwerkerd handwerkerd self-assigned this Jul 19, 2021
@tsalo
Copy link
Member

tsalo commented Jul 19, 2021

Agreed. I should have updated the minimum version in #696. However, I don't think there's any benefit to listing required versions outside of info.py (or even, really, the requirements themselves), since the installation will manage those dependency versions automatically based on the contents of info.py.

@handwerkerd
Copy link
Member Author

Based on the above comment, the plan is to remove the existing version numbers (except for the python version number) from README.md and installation.rst and then update info.py to match the minimum requirements from nilearn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to improving documentation for the project effort: low Theoretically less than a day's work impact: low Improving code/documentation cleanliness/clarity, not function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants