Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions do not work for Windows machines #844

Closed
aryangupta701 opened this issue Feb 18, 2022 · 18 comments · Fixed by #846
Closed

Installation instructions do not work for Windows machines #844

aryangupta701 opened this issue Feb 18, 2022 · 18 comments · Fixed by #846
Labels
bug issues describing a bug or error found in the project documentation issues related to improving documentation for the project

Comments

@aryangupta701
Copy link
Contributor

Hello,

I am getting errors while using the command "pip install -e .'[all]'"
Can anyone help me to fix this please, I want to contribute to this project.

Thankyou

@tsalo
Copy link
Member

tsalo commented Feb 18, 2022

Can you post the traceback?

@aryangupta701
Copy link
Contributor Author

ERROR: Invalid requirement: '[all]'
I get this error

@tsalo
Copy link
Member

tsalo commented Feb 18, 2022

I can't reproduce locally, so maybe it's a version or path issue. Let's see if we can diagnose the problem.

  • Where are you running this command from? Is it from the tedana directory?
  • Is your local copy of tedana up-to-date with main?
  • What version of pip are you using?
  • What version of Python are you using?

@aryangupta701
Copy link
Contributor Author

I have copied this command from CONTRUBUTING.md file present in the project
yes my local copy is up to date
my pip version is latest
python version 3.8

@tsalo
Copy link
Member

tsalo commented Feb 18, 2022

I have copied this command from CONTRIBUTING.md file present in the project

Yes, but in what location on your filesystem did you run the command?

Maybe it's an OS issue. What operating system are you using?

Lastly, can you try pip install -e .[all] (no single quotes around [all]).

@aryangupta701
Copy link
Contributor Author

yes this worked thanks a lot.

@tsalo
Copy link
Member

tsalo commented Feb 18, 2022

Are you using a Windows machine by any chance? I'd like to make sure our installation instructions work for all operating systems, so we may need to update them if they don't work for Windows machines.

@tsalo tsalo added bug issues describing a bug or error found in the project documentation issues related to improving documentation for the project labels Feb 18, 2022
@aryangupta701
Copy link
Contributor Author

Yes I am using a windows 11 machine

@tsalo
Copy link
Member

tsalo commented Feb 18, 2022

Thank you.

@ME-ICA/tedana-devs do any of you use a Windows machine? Can you reproduce the behavior @aryangupta701 reported with pip install -e .'[all]'?

@handwerkerd
Copy link
Member

Welcome @aryangupta701 ! I don't have easy access to a Windows computer right now so I can't help directly. This sounds like a really important issue to resolve.

@eurunuela
Copy link
Collaborator

My colleague @vinferrer has a Windows I believe. We could have a look on Monday.

@Cristina-Tobias
Copy link

I have tried installing tedana both ways in my Windows laptop. It has only worked without the single quotes

@tsalo
Copy link
Member

tsalo commented Feb 22, 2022

What about pip install -e '.[all]'?

@Cristina-Tobias
Copy link

It showed this error message : ERROR: .'[all]' is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with svn+, git+, hg+, or bzr+)

@eurunuela
Copy link
Collaborator

What about pip install -e '.[all]'?

That didn't work. We're gonna have to update our docs.

@tsalo
Copy link
Member

tsalo commented Feb 22, 2022

No, not .'[all]'. '.[all]'.

EDIT: For clarification, I ask because that's the pattern that came up recently in a nilearn PR of mine: nilearn/nilearn#2953 (comment)

@Cristina-Tobias
Copy link

Sorry. I have tried it again with '.[all]' and it shows the same error message

@tsalo
Copy link
Member

tsalo commented Feb 22, 2022

Thank you @Cristina-Tobias, that's really helpful for nilearn too.

@aryangupta701 we can follow up in #846 about how specifically we should update the installation instructions.

@tsalo tsalo changed the title problem with local machine setup Installation instructions do not work for Windows machines Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues describing a bug or error found in the project documentation issues related to improving documentation for the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants