Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS2EXE] Add -noExtract parameter #3

Closed
Hope-IT-Works opened this issue Aug 8, 2020 · 2 comments
Closed

[PS2EXE] Add -noExtract parameter #3

Hope-IT-Works opened this issue Aug 8, 2020 · 2 comments

Comments

@Hope-IT-Works
Copy link

Hope-IT-Works commented Aug 8, 2020

Hello Markus,

i have a feature for ps2exe that is very nice to have.

I've contacted Ingo Karstein, the original author of ps2exe and asked him, how i could remove the -extract feature from the ps2exe-script. He told me it's as simple as removing this else-if from the script:

							else if (s.StartsWith("-extract", StringComparison.InvariantCultureIgnoreCase))
							{
								string[] s1 = s.Split(new string[] { ":" }, 2, StringSplitOptions.RemoveEmptyEntries);
								if (s1.Length != 2)
								{
$(if (!$noConsole) {@"
									Console.WriteLine("If you specify the -extract option you need to add a file for extraction in this way\r\n   -extract:\"<filename>\"");
"@ } else {@"
									MessageBox.Show("If you specify the -extract option you need to add a file for extraction in this way\r\n   -extract:\"<filename>\"", System.AppDomain.CurrentDomain.FriendlyName, MessageBoxButtons.OK, MessageBoxIcon.Error);
"@ })
									return 1;
								}
								extractFN = s1[1].Trim(new char[] { '\"' });
							}

It would be great if you would add a -noExtract feature for the ps2exe-script.

Thanks in advance and have a nice day,
@Hope-IT-Works

@MScholtes
Copy link
Owner

Hello ChocolateDay | Tobias Meyer,

I am a big fan of free software, so PS2EXE itself is free. I am reluctant to make the compilations generated by PS2EXE closed source.

There may be situations where this makes sense. Please replace the expression s.StartsWith("-extract", StringComparison.InvariantCultureIgnoreCase) in PS2EXE.ps1 with the expression false then the parameter -extract is gone for future compilations.

Greetings

Markus

@MScholtes
Copy link
Owner

Closed since no response for over 2 weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants