fix(fields): fix pointer-events in Select #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
=======================================
Coverage 57.49% 57.49%
=======================================
Files 55 55
Lines 807 807
Branches 274 274
=======================================
Hits 464 464
- Misses 327 343 +16
+ Partials 16 0 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
louptheron
force-pushed
the
loup/fix-pointer-events-on-select
branch
from
cb9fc4d
to
c7427ac
Compare
ivangabriele
force-pushed
the
loup/fix-pointer-events-on-select
branch
from
c7427ac
to
eb59921
Compare
ivangabriele
changed the title
maximeperraultdev
approved these changes
Sep 25, 2024
src/fields/Select.tsx
Outdated
| return | ||
| } | ||
|
|
||
| const divs = boxRef.current!.querySelectorAll(`#${originalProps.name}-listbox div`) |
There was a problem hiding this comment.
todo: pas besoin du ! de current si tu le testes avant
louptheron
force-pushed
the
loup/fix-pointer-events-on-select
branch
from
e7d3aa0
to
49449ba
Compare
|
🎉 This PR is included in version 23.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues
Preview URL
https://637e01cf5934a2ae881ccc9d-cgnhnmvxpo.chromatic.com/