feat(components): add message component #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louptheron
force-pushed
the
loup/add-message-component
branch
from
5e1e0f4
to
7f3c640
Compare
ivangabriele
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Plusieurs petites remarques :
- Je l'aurais plutôt appelé
Alert - Pour moi c'est un
elementet pas uncomponentcar il n'a pas de (grande) logique interne - Pour
ExclamationPoint, si tu veux en faire un élément root, je suppose que c'est parce qu'on va l'utiliser ailleurs ? Si la réponse est oui, je l'aurais plutôt mis dans un nouveau dossier pour ça (l'idéal sera d'en faire une icône) du genresymbols/.
claire2212
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Je me demande si on devrait pas anticiper un peu (oui je sais il faut pas) en faisant direct une version accent.PRIMARY avec le orange + point d'exclamation.
Je pense qu'on aura plus tard une version rouge en cas d'erreur + une version verte en cas de success.
T'en penses quoi?
|
🎉 This PR is included in version 10.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues
Preview URL
https://637e01cf5934a2ae881ccc9d-xfjgieiuth.chromatic.com/