-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Préavis – Consulter la liste des préavis #2843
Comments
|
## Linked issues - Resolve #2484 - Resolve #2843 - Resolve #2844 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a comprehensive system for monitoring fishing activities through prior notifications, including vessel information, catches, and risk assessments. - Added functionality to retrieve and filter prior notifications and logbook reports based on various criteria such as dates, locations, and vessel details. - Implemented a new frontend component for displaying a list of prior notifications with capabilities for filtering, sorting, and accessing detailed views. - **Enhancements** - Enhanced the retrieval of prior notifications with additional details like port names and seafront information. - Refined the vessel entity representation in the frontend to improve data handling and presentation. - **Bug Fixes** - Fixed issues related to the incorrect handling of null values in vessel identity properties. - **Tests** - Added unit and integration tests to ensure the reliability of new functionalities related to prior notifications and logbook reports. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…es navires ou celle des facteurs de risque [WORKAROUND] (#3108) ## Linked issues - #2843 - #2867 - #3107 ---- - [ ] Tests E2E (Cypress) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new interface for managing vessel risk factors, enhancing the ability to retrieve and map risk factors based on internal reference numbers. - Enhanced vessel information retrieval capabilities with new functions and caching mechanisms in repository classes. - **Bug Fixes** - Standardized naming conventions across various classes and methods to ensure consistency in risk factor management. - **Refactor** - Renamed multiple repository and class references to align with updated naming conventions. - **Documentation** - Updated test cases and comments to reflect changes in functionality and improve clarity. - **Chores** - Implemented new database entries for vessels and risk factors to support testing and development. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Revue de la vue liste des préavisVue générale
Vue détaillée des lignes de préavis
|
## Linked issues - #2843 ---- - [ ] Tests E2E (Cypress)
À gérer côté data à priori de ce que j'ai checké. UPDATE Vu avec Vincent : ce sera ajouté aux nouveaux PNOs lors de l'enrichissement mais ceux existants sur le staging n'en n'ont pas en effet.
Same, à gérer côté data à priori de ce que j'ai checké. UPDATE Important Il faut changer tous les noms en français dans le back-office AVANT qu'on enrichisse les données en prod. Sur le staging je ne sais pas trop par contre.
Ça je sens que ça va être un joli challenge UI, les seules solutions que je vois pour l'instant demandent à revoir la structure du composant commun qu'on utilise pour les tableau. Je vais en discuter pour voir si une idée plus simple existe. |
@louptheron Normalement c'est fixé sur ma PR préavis en cours ça (tout comme sur les missions d'ailleurs) |
## Linked issues - #2843 ---- - [ ] Tests E2E (Cypress)
|
Les 2 points encore non traités sont dans des tickets : |
Les derniers points me semblent réglés ! |
En tant qu'unité, au bureau, je veux pouvoir consulter la liste des préavis pour :
The text was updated successfully, but these errors were encountered: