[Couches admin.] Correction de l'affichage des zones FAO non prises en charge #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
claire2212
approved these changes
Sep 14, 2023
ivangabriele
approved these changes
Sep 14, 2023
| @@ -271,14 +252,14 @@ export const LayerProperties: Record<MonitorFishLayer, ShowableLayer> = { | |||
| name: 'Zones Cormoran (NAMO-SA)', | |||
| type: LayerType.ADMINISTRATIVE, | |||
| hasSearchableZones: true, | |||
| subZoneFieldKey: 'zonex', | |||
| zoneNamePropertyKey: 'zonex', | |||
There was a problem hiding this comment.
zoneNameProp ou zoneNamePropertyName ? J'avoue que ce n'est pas facile à nommer. C'est à ça que servent les enums pour le coup mais ça complexifierait peut-être le code pour rien. Suggestion très optionnelle.
There was a problem hiding this comment.
Mhm il n'y a rien qui me convainc trop, zoneNameProp c'est trop evasif et zoneNamePropertyName répétition de Name (non technique puis technique)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
27.5.b.1.aet27.5.b.1.bn'apparaissent pas sur la cartographie dans les couchefao_areas#2498