Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cartographie] Améliorations bandeau jaune de dysfonctionnement VMS ou JPE #2662

Merged
merged 9 commits into from
Nov 1, 2023
Merged

[Cartographie] Améliorations bandeau jaune de dysfonctionnement VMS ou JPE #2662

merged 9 commits into from
Nov 1, 2023

Conversation

VincentAntoine
Copy link
Collaborator

@VincentAntoine VincentAntoine commented Oct 26, 2023 •
edited by louptheron
Loading

@louptheron louptheron changed the title Vincent/improve vms failure alert visual [Cartographie] Améliorations bandeau jaune de dysfonctionnement VMS ou JPE Oct 30, 2023
@louptheron louptheron marked this pull request as ready for review October 30, 2023 16:15
@codecov-commenter
Copy link

We're currently processing your upload. This comment will be updated when the results are available.

ivangabriele
ivangabriele approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ivangabriele ivangabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deux petites remarques :

  • Pourquoi on passe la healthcheckTextWarning prop partout alors qu'on pourrait éviter tous ces passages de prop en l'appelant directement via Redux dans le composant concerné ?
  • Je serais d'avis d'en profiter pour renommer de manière plus conventionnelle healthcheckTextWarning => hasHealthcheckWarning.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louptheron louptheron merged commit 36bc585 into master Nov 1, 2023
25 checks passed
@louptheron louptheron deleted the vincent/improve_vms_failure_alert_visual branch November 1, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Améliorations bandeau jaune de dysfonctionnement VMS ou JPE
4 participants
@VincentAntoine @codecov-commenter @ivangabriele @louptheron