Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Missions] Migration des champs d'infractions en bas du formulaire de contrôle #2668

Merged
merged 3 commits into from
Nov 1, 2023
Merged

[Missions] Migration des champs d'infractions en bas du formulaire de contrôle #2668

merged 3 commits into from
Nov 1, 2023

Conversation

louptheron
Copy link
Collaborator

ivangabriele
ivangabriele approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@ivangabriele ivangabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'aime la petite attention de détail où tu as repositionné les tests e2e pour les faire correspondre avec le nouvel ordre du formulaire :)

frontend/src/domain/types/infraction.ts Outdated Show resolved Hide resolved
.../src/features/SideWindow/MissionForm/ActionForm/shared/FormikMultiInfractionPicker/index.tsx Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louptheron louptheron merged commit a80e779 into master Nov 1, 2023
25 checks passed
@louptheron louptheron deleted the loup/move-infractions-fields-bottom branch November 1, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missions - Migration des champs d'infractions en bas du formulaire de contrôle
2 participants
@louptheron @ivangabriele