-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Missions] Rafraichissement & Enregistrement automatique (UPDATE ENV VAR) #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louptheron
force-pushed
the
loup/auto-saving
branch
2 times, most recently
from
December 6, 2023 16:56
09cd83f
to
a593036
Compare
louptheron
force-pushed
the
loup/auto-saving
branch
from
December 13, 2023 09:37
736ed09
to
99918b3
Compare
louptheron
changed the title
[Missions] Enregistrement automatique
[Missions] Rafraichissement & Enregistrement automatique
Dec 13, 2023
louptheron
force-pushed
the
loup/auto-saving
branch
from
December 13, 2023 16:09
466621b
to
df3f116
Compare
claire2212
reviewed
Dec 18, 2023
claire2212
reviewed
Dec 18, 2023
claire2212
reviewed
Dec 18, 2023
frontend/src/features/SideWindow/MissionForm/ActionForm/AirControlForm.tsx
Outdated
Show resolved
Hide resolved
claire2212
reviewed
Dec 18, 2023
claire2212
reviewed
Dec 18, 2023
claire2212
reviewed
Dec 18, 2023
frontend/src/features/SideWindow/MissionForm/MainForm/index.tsx
Outdated
Show resolved
Hide resolved
louptheron
changed the title
[Missions] Rafraichissement & Enregistrement automatique
[Missions] Rafraichissement & Enregistrement automatique (BREAKING)
Dec 20, 2023
louptheron
changed the title
[Missions] Rafraichissement & Enregistrement automatique (BREAKING)
[Missions] Rafraichissement & Enregistrement automatique (BREAKING CHANGES)
Dec 20, 2023
louptheron
changed the title
[Missions] Rafraichissement & Enregistrement automatique (BREAKING CHANGES)
[Missions] Rafraichissement & Enregistrement automatique (UPDATE ENV VAR)
Dec 20, 2023
thoomasbro
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 6 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
FRONTEND_MISSION_AUTO_SAVE_ENABLED
Quelques notes :
isDirty
correspond maintenant au fait que les formulaires soient en erreur (et du coup non-enregistrés en backend): la modale de fermeture s'affiche donc quand le formulaire est en erreurEVENT_SOURCE.addEventListener(MISSION_UPDATE_EVENT, listener)
est maintenant dans le formulaire Formik (MissionForm/MainForm/FormikSyncMissionFields.tsx
) et mets à jour directement les champs avecsetFieldValue
. Cela permet de ne pas perdre le focus (re-render le formulaire) quand on reçoit une MAJ d'un autre poste.waitForLastRequest
car il y a une requête qui part à chaque modification, uncy.wait('@updatedMission')
ne pouvait pas attendre la bonne requêteClôturer
en attendant de changer les statuts de missionsdraft
(la mission) mais je dois le garder pour les actions transverses (i.e formulaire d'action qui met à jour le formulaire de mission, etc.)onChange
des formulaires de mission ou d'action, le state deMissionForm
et le state reduxdraft
sont mis à jour, même lorsque les formulaires sont en erreurs. La requête d'update
ne part que quand la validation sur les formulaires passeOverlay
sur une mission soit à jour.