Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech] Downgrade cypress to v12 #2721

Merged
merged 6 commits into from
Nov 27, 2023
Merged

[Tech] Downgrade cypress to v12 #2721

merged 6 commits into from
Nov 27, 2023

Conversation

louptheron
Copy link
Collaborator

@louptheron louptheron commented Nov 23, 2023 •
edited by ivangabriele
Loading

Linked issues

There was an error reconnecting to the Chrome DevTools protocol. Please restart the browser.

TypeError: Cannot read properties of undefined (reading 'webSocketDebuggerUrl')
    at _._fetchDebuggerURL (<embedded>:2404:524567)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async _._start (<embedded>:2404:523866)
  • Upgrade de Firefox pour être à jour
  • Mise sous silence de l'erreur : AbortError: The operation was aborted qui apparait seulement avec un reload() sous Cypress
  • Ajout d'un script pour tester le comportement d'un flaky test à répétition
  • Tests E2E (Cypress)

@louptheron louptheron marked this pull request as ready for review November 23, 2023 17:05
ivangabriele
ivangabriele approved these changes Nov 23, 2023
View reviewed changes
frontend/cypress/support/test_flaky_test.sh Outdated
@@ -0,0 +1,11 @@
counter=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu veux laisser ce script ? Si oui, peut-être l'ajouter dans les scripts npm avec un petit arg pour donner le path du test ?

frontend/cypress/support/e2e.ts
// return false // return false to make test continue
// }

// We ignore uncaught exceptions `AbortError: The operation was aborted`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un petit comment sur le genre de case ou ça arrive ?

@ivangabriele ivangabriele changed the title [Tech] Downgrade cypress [Tech] Downgrade cypress to v12 Nov 23, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivangabriele ivangabriele merged commit ae59167 into master Nov 27, 2023
25 checks passed
@ivangabriele ivangabriele deleted the loup/fix-cypress-flaky-tests branch November 27, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louptheron @ivangabriele