Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unités carto] Régler l'affichage de l'Overlay #2799

Merged
merged 6 commits into from
Jan 16, 2024
Merged

[Unités carto] Régler l'affichage de l'Overlay #2799

merged 6 commits into from
Jan 16, 2024

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Jan 8, 2024 •
edited
Loading

@ivangabriele ivangabriele changed the title Ivan/fix multiple issues in stations [Unités carto] Régler l'affichage de l'Overlay Jan 8, 2024
@ivangabriele ivangabriele force-pushed the ivan/fix-multiple-issues-in-stations branch 3 times, most recently from 54d07f8 to 83b9050 Compare January 11, 2024 10:17
@ivangabriele ivangabriele marked this pull request as ready for review January 11, 2024 10:21
louptheron
louptheron approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@louptheron louptheron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Deux remarques :

  • On pourrait rajouter un grabbing sur le header de SelectedOverlay ?
  • On ne garde pas en mémoire (dans le localstorage) l'affichage ou non des unités, ça serait pas mal non (hors scope PR) ?

@ivangabriele ivangabriele mentioned this pull request Jan 16, 2024
Open
@ivangabriele ivangabriele force-pushed the ivan/fix-multiple-issues-in-stations branch from ce69a5a to 623ffa2 Compare January 16, 2024 15:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivangabriele ivangabriele merged commit 4e6169d into master Jan 16, 2024
24 checks passed
@ivangabriele ivangabriele deleted the ivan/fix-multiple-issues-in-stations branch January 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louptheron louptheron louptheron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unités – Affichage des bases sur la carte [Unités carto] Régler l'affichage de l'Overlay
2 participants
@ivangabriele @louptheron