Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Préavis] Fixe les cas comportant des CFRs dupliqués dans la tables des navires ou celle des facteurs de risque #3107

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Apr 15, 2024

Linked issues


  • Tests E2E (Cypress)

Summary by CodeRabbit

  • New Features

    • Enhanced vessel tracking by allowing multiple vessels and risk factors to be associated with logbook reports.
  • Data Updates

    • Inserted new vessel entries and updated risk factor records in the database.
    • Added new logbook report entries for operations, improving data richness and accuracy.

Copy link
Contributor

coderabbitai bot commented Apr 15, 2024

Walkthrough

The recent updates bring changes to the database and backend, enabling support for multiple vessels per logbook report and introducing new risk factors. Test data additions enhance the system's capabilities for handling complex scenarios involving vessel operations and risk assessments.

Changes

Files Change Summary
.../entities/LogbookReportEntity.kt Updated LogbookReportEntity: vessel replaced with vessels, vesselRiskFactor with vesselRiskFactors. Adjusted logic in fromLogbookMessage.
.../db/testdata/*.sql & *.jsonc Added new vessel entries, logbook reports, and risk factor records.

Poem

🐇✨
In the realm of code, where the data hops around,
New vessels sail, where once was none found.
With logbooks a-plenty and risks to chart,
The rabbits of code play their part.
Hop, hop, hop, on silicon seas,
Crafting the nets with the greatest of ease! 🚀🐰


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e1778e5 and 2712778.
Files selected for processing (2)
  • backend/src/main/resources/db/testdata/V666.11__Insert_risk_factors.sql (1 hunks)
  • backend/src/main/resources/db/testdata/json/V666.11__Insert_risk_factors.jsonc (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • backend/src/main/resources/db/testdata/V666.11__Insert_risk_factors.sql
  • backend/src/main/resources/db/testdata/json/V666.11__Insert_risk_factors.jsonc

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ivangabriele ivangabriele force-pushed the ivan/fix-prior-notifications-with-duplicate-cfr-in-risk-factors-and-vessel-table branch from c66f798 to e1778e5 Compare April 15, 2024 10:59
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivangabriele ivangabriele marked this pull request as draft April 15, 2024 13:51
ivangabriele added a commit that referenced this pull request Apr 15, 2024
…es navires ou celle des facteurs de risque [WORKAROUND] (#3108)

## Linked issues

- #2843
- #2867
- #3107

----

- [ ] Tests E2E (Cypress)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new interface for managing vessel risk factors, enhancing
the ability to retrieve and map risk factors based on internal reference
numbers.
- Enhanced vessel information retrieval capabilities with new functions
and caching mechanisms in repository classes.

- **Bug Fixes**
- Standardized naming conventions across various classes and methods to
ensure consistency in risk factor management.

- **Refactor**
- Renamed multiple repository and class references to align with updated
naming conventions.

- **Documentation**
- Updated test cases and comments to reflect changes in functionality
and improve clarity.

- **Chores**
- Implemented new database entries for vessels and risk factors to
support testing and development.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@ivangabriele ivangabriele deleted the ivan/fix-prior-notifications-with-duplicate-cfr-in-risk-factors-and-vessel-table branch May 21, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant