Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comma separation for tags in the UI #1763

Closed
qubodup opened this issue May 11, 2024 · 2 comments
Closed

Add comma separation for tags in the UI #1763

qubodup opened this issue May 11, 2024 · 2 comments

Comments

@qubodup
Copy link

qubodup commented May 11, 2024

YouTube and any other user created content website I can think of that has a 'tags' or 'keywords' filed, uses the ',' character as a separator but freesound does not.

Here is the upload description form ( https://freesound.org/home/describe/sounds/ ):
upload description form
In the screenshot above, I am in the process of writing 'hello'.
If I press ',', nothing happens. No ',' is added but the current word is not confirmed.
If I press spacebar or enter, the tag 'hello is added and the next tag entry starts.

Here is a YouTube Tags field:
image
Here is a DeviantArt one:
image
Here is an OpenClipArt one (accidentally took a screenshot after confirming, unstable site doesn't respond right now, so leaving this for now):
image
In all 3 cases, if I press ',' the tag is confirmed and the next tag entry starts.

While the ability to use ' ' inside of tags varies (on some sites, ' ' will end the current tag and start the next), using ',' is most certainly standardized. This means the user experience of freesound is slightly off in a moment of potential high concentration in which the sound designer is focusing on the terms that might be good describers and potentially even looks at the keyboard to type, expecting ',' to do what it always does. This can interrupt the focused work and frustrate if noticed late.

I'd like to suggest that pressing ',' should confirm and separate tags in the input field

The most common way to store lists of tags is in newline or comma separated strings (with or without space after comma):
tag1ä
tag2ß
tag3ü

tag4ภาษาไทย,tag5, tag6

If I paste the above into the tag field on freesound, this is the result:
image

I'd like to suggest that pasting text that contains ',' should use these as separators

The text

Add at least 3 tags, separating them with spaces. Join multi-word tags with dashes. For example: field-recording is a popular tag. Only use letters a-z and numbers 0-9 with no accents or diacritics. Note that you can copy and paste between tag fields.

could be updated to

Add at least 3 tags, separating them with spaces (and/or commas). Join multi-word tags with dashes. For example: field-recording is a popular tag. Only use letters a-z and numbers 0-9 with no accents or diacritics. Note that you can copy and paste between tag fields.

diff

Side note, this text is rather long and could be shrunk to:

At least 3 tags, separated by spaces (and/or commas), join words with dashes (example: field-recording), only letters (a-z) and numbers (0-9), no accents/diacritics. You can copy/paste between tag fields.

diff

@ffont
Copy link
Member

ffont commented Oct 8, 2024

In cfb549c I implemented the idea of using , as tags separator.
Still missing:

  • Improve help text
  • "Consolidate" tags when scrolling down the page to avoid an "unfinished" tag to be skipped when submitting form

@ffont
Copy link
Member

ffont commented Oct 15, 2024

All fixed in 3cc7695 and a12439a! Will be merge soon.

@ffont ffont closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants