Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using DYNAMIC_LIST did not work: all kernels are still built #180

Closed
mattip opened this issue Aug 11, 2024 · 2 comments · Fixed by #182
Closed

Using DYNAMIC_LIST did not work: all kernels are still built #180

mattip opened this issue Aug 11, 2024 · 2 comments · Fixed by #182

Comments

@mattip
Copy link
Collaborator

mattip commented Aug 11, 2024

In spite of specifying DYNAMIC_LIST in the make cmmand, all the kernels were built in #177, resulting in no change in the v0.3.27.44.5 wheels (vis-a-vis the v0.3.27.44.4 ones), so the NumPy 2.1.0rc1 wheels are no smaller. This is different from #166 where the wheel size was smaller.

Still investigating what went wrong. I guess I never looked at the actual size of the binary before merging #177.
@mattip
Copy link
Collaborator Author

mattip commented Aug 11, 2024

I got fooled by windows, which did produce a smaller shared object/wheel.

This was referenced Aug 12, 2024
Merged
Merged
Merged
@mattip
Copy link
Collaborator Author

mattip commented Aug 12, 2024

Closed by #181 for 0.3.27.44, #182 for main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cherry-pick changes to shrink wheel mattip/openblas-libs
1 participant
@mattip