-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add symbolprefix=scipy #125
Conversation
…libopenblas_python
This is ready if anyone wants to review. I don't think we need to change the wheel names for the changed function names. This is a new version |
fi | ||
# if [ "macos-11" == "${{ matrix.os }}" ]; then | ||
# echo "LDFLAGS=-L/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/usr/lib" >> $GITHUB_ENV; | ||
# echo "LIBRARY_PATH=-L/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/usr/lib" >> $GITHUB_ENV; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll note that if this is needed again in the future or changes, there's a better way than hardcoding it. The path can be obtained from xcrun --sdk macosx --show-sdk-path
. I just managed to get rid of this hardcoding in numpy CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment in the commit to add the BLAS_SYMBOL_PREFIX definition to the pkgconfig file
Currently if you use the ILP64 builds, you have to add |
We can't in general, because there are libraries that have both LP64 and ILP64 symbols. True right now for at least MKL and Accelerate, and may also be true for OpenBLAS sometime next year (after reference BLAS/LAPACK adopts it). It has to be a user opt-in. It may be okay for the opt-in to be automatic for |
It worked locally, with the latest commit I can do
|
It turns out we need to add a symbol prefix in order to use the wheels, otherwise there are clashes with other builds of OpenBLAS and/or other BLAS implementations. This adds a
SYMBOLPREFIX=scipy
to these builds. Also