-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a single shared object libscipy_openblas64_.so or libscipy_openblas.so #128
Conversation
580b9c8
to
83c40b6
Compare
There are some downstream projects using the tarball. here is a github search. This PR changes the shared objects in the tarball, I wonder if it will break their build. I asked on on the jdtuc/fdasrsf_python project. |
They all have copied the numpy/scipy script which pins to an exact hash, so I wouldn't worry about it. This repo is "use at your own risk" anyway. |
a013721
to
cc2c71c
Compare
cc2c71c
to
8bff0b2
Compare
33dc2f8
to
8cbcf24
Compare
8cbcf24
to
2cf9674
Compare
This works locally, even with the older tarballs. But it requires one change from numpy/numpy#25505: this fix for when scipy-openblas is detected by meson. So in order not to override the current tarball, which is used by numpy builds, I will bump the OpenBLAS version, which is overdue anyway. |
Related to numpy/numpy#25505
Instead of building a set of shared objects and creating symlinks to them, create only a single shared object. Use a patch to OpenBLAS.