Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a single shared object libscipy_openblas64_.so or libscipy_openblas.so #128

Merged
merged 10 commits into from
Jan 25, 2024

Conversation

mattip
Copy link
Collaborator

@mattip mattip commented Jan 19, 2024

Related to numpy/numpy#25505

Instead of building a set of shared objects and creating symlinks to them, create only a single shared object. Use a patch to OpenBLAS.

@mattip
Copy link
Collaborator Author

mattip commented Jan 23, 2024

There are some downstream projects using the tarball. here is a github search. This PR changes the shared objects in the tarball, I wonder if it will break their build. I asked on on the jdtuc/fdasrsf_python project.

@rgommers
Copy link
Collaborator

They all have copied the numpy/scipy script which pins to an exact hash, so I wouldn't worry about it. This repo is "use at your own risk" anyway.

@mattip mattip force-pushed the patch-external branch 3 times, most recently from a013721 to cc2c71c Compare January 23, 2024 14:57
@mattip
Copy link
Collaborator Author

mattip commented Jan 25, 2024

This works locally, even with the older tarballs. But it requires one change from numpy/numpy#25505: this fix for when scipy-openblas is detected by meson. So in order not to override the current tarball, which is used by numpy builds, I will bump the OpenBLAS version, which is overdue anyway.

@mattip mattip merged commit 020da30 into MacPython:main Jan 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants