Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Node 12 support #80

Closed
kryops opened this issue Apr 30, 2019 · 1 comment · Fixed by #81
Closed

Node 12 support #80

kryops opened this issue Apr 30, 2019 · 1 comment · Fixed by #81
Assignees

Comments

@kryops
Copy link
Contributor

kryops commented Apr 30, 2019

Hi there!

I tried upgrading my application to Node 12, and the following compile errors were thrown:

  • v8::Handle does not exist any more
  • args[i]->NumberValue() does not work any more

I don't really know C++, but I managed to get it working with the following changes:

https://github.com/kryops/node-usb-detection/commit/20ebc8bc2ade4319087d6476cf9f556c1c582b84

Could you please check if they make sense and don't break anything else (especially older versions of Node), and upgrade this package accordingly?

Thanks!

See also:
bcoin-org/bcrypto#7
nodejs/node#23122

@MadLittleMods
Copy link
Owner

@kryops Mind creating a pull request so we can add comments to the code itself that will be self contained in this project?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants