From bc27c46723a31db40e584cfb6cd02fdc8aee1585 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= <github@bugsounet.fr>
Date: Wed, 19 Jun 2024 22:11:04 +0200
Subject: [PATCH] =?UTF-8?q?MM=C2=B2=20Main=20core=20use=20node=20>=3D=20v2?=
 =?UTF-8?q?0=20//=20delete=20node=20v18=20from=20test=20suite=20(#3463)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

#3462
---
 .github/workflows/automated-tests.yaml | 2 +-
 .github/workflows/electronRebuild.yaml | 8 ++++++++
 CHANGELOG.md                           | 3 +++
 package.json                           | 2 +-
 4 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml
index 18795146b6..301b08d47b 100644
--- a/.github/workflows/automated-tests.yaml
+++ b/.github/workflows/automated-tests.yaml
@@ -18,7 +18,7 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 22.x]
+        node-version: [20.x, 22.x]
     steps:
       - name: "Checkout code"
         uses: actions/checkout@v4
diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml
index 5c6e3f7db3..f9cc50957f 100644
--- a/.github/workflows/electronRebuild.yaml
+++ b/.github/workflows/electronRebuild.yaml
@@ -6,9 +6,17 @@ jobs:
   rebuild:
     name: Run electron-rebuild
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [20.x, 22.x]
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
+      - name: "Use Node.js ${{ matrix.node-version }}"
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          check-latest: true
       - name: Install MagicMirror
         run: npm run install-mm
       - name: Install @electron/rebuild
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 10edb8aaa6..e37ab714f3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,9 +13,12 @@ _This release is scheduled to be released on 2024-07-01._
 
 ### Removed
 
+- [test suite] delete node v18 support
+
 ### Updated
 
 - [chore] Update dependencies including electron to v30
+- [core] use node >= v20
 
 ### Fixed
 
diff --git a/package.json b/package.json
index 25c4622f58..c7aebff9d5 100644
--- a/package.json
+++ b/package.json
@@ -95,7 +95,7 @@
 		"electron": "^30.1.0"
 	},
 	"engines": {
-		"node": ">=18"
+		"node": ">=20"
 	},
 	"_moduleAliases": {
 		"node_helper": "js/node_helper.js",