Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in newsfeed module using removeStartTags on a description #1478

Closed
michael5r opened this issue Dec 7, 2018 · 3 comments
Closed

Bug in newsfeed module using removeStartTags on a description #1478

michael5r opened this issue Dec 7, 2018 · 3 comments

Comments

@michael5r
Copy link
Contributor

Platform: Raspberry Pi 3, Mac
Node Version: 8.9.0
MagicMirror Version: 2.5

Description:
There's a bug in the default newsfeed module in newsfeed.js when removeStartTags is used on the description - it's copying the sliced result back into the title, instead of the description.

Line 141

this.newsItems[this.activeItem].title = ... [snip]

should be:

this.newsItems[this.activeItem].description = ... [snip]
@michael5r
Copy link
Contributor Author

I'd be happy to open a PR for this tiny change, but I was unable to find code contribution guidelines.

@MichMich
Copy link
Collaborator

PR to the develop branch is more than welcome. Thanks! Dont forget to add the changelog.

@michael5r michael5r mentioned this issue Dec 10, 2018
Merged
@MichMich
Copy link
Collaborator

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichMich @michael5r