Weather module: Wind arrow is inverted #3019
Comments
|
I am going to fix this, but should I hide it behind a setting and leave the current arrow as the default? That way no one will get the change forced on them. However, I think most people want the inverted arrow. |
rejas
added
bug
ready (coming with next release)
and removed
ready (coming with next release)
labels
|
I also think that we should have the arrow pointed in the direction the wind is going. That makes most sense. Thanks for your report (and hopefully your fix ;-) |
rejas
pushed a commit
that referenced
this issue
Jan 22, 2023
Fixes #3019 The previous implementation had the arrow pointing in to the wind. When the wind blows from the north (0 degrees), the arrow should point straight down. In other words, no rotation of the arrow-down symbol. When the wind blows from the south (180 degrees), the arrow should point straight up (I.e. the arrow down symbol rotated 180 degrees). Co-authored-by: Magnus Marthinsen <magmar@online.no>
|
Thx for your PR! |
MichMich
added a commit
that referenced
this issue
Apr 4, 2023
## [2.23.0] - 2023-04-04 Thanks to: @angeldeejay, @buxxi, @CarJem, @dariom, @DaveChild, @dWoolridge, @grenagit, @Hirschberger, @KristjanESPERANTO, @MagMar94, @naveensrinivasan, @nfogal, @psieg, @rajniszp, @retroflex, @SkySails and @tomzt. Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not all) of the work on this release as project collaborators. This version would not be there without their effort. Thank you guys! You are awesome! ### Added - Added increments for hourly forecasts in weather module (#2996) - Added tests for hourly weather forecast - Added possibility to ignore MagicMirror repo in updatenotification module - Added Pirate Weather as new weather provider (#3005) - Added possibility to use your own templates in Alert module - Added error message if `<modulename>.js` file is missing in module folder to get a hint in the logs (#2403) - Added possibility to use environment variables in `config.js` (#1756) - Added option `pastDaysCount` to default calendar module to control of how many days past events should be displayed - Added thai language to alert module - Added option `sendNotifications` in clock module (#3056) ### Removed - Removed darksky weather provider - Removed unneeded (and unwanted) '.' after the year in calendar repeatingCountTitle (#2896) ### Updated - Use develop as target branch for dependabot - Update issue template, contributing doc and sample config - The weather modules clearly separates precipitation amount and probability (risk of rain/snow) - This requires all providers that only supports probability to change the config from `showPrecipitationAmount` to `showPrecipitationProbability`. - Update tests for weather and calendar module - Changed updatenotification module for MagicMirror repo only: Send only notifications for `master` if there is a tag on a newer commit - Update dates in Calendar widgets every minute - Cleanup jest coverage for patches - Update `stylelint` dependencies, switch to `stylelint-config-standard` and handle `stylelint` issues, update `main.css` matching new rules - Update Eslint config, add new rule and handle issue - Convert lots of callbacks to async/await - Revise require imports (#3071 and #3072) ### Fixed - Fix wrong day labels in envcanada forecast (#2987) - Fix for missing default class name prefix for customEvents in calendar - Fix electron flashing white screen on startup (#1919) - Fix weathergov provider hourly forecast (#3008) - Fix message display with HTML code into alert module (#2828) - Fix typo in french translation - Yr wind direction is no longer inverted - Fix async node_helper stopping electron start (#2487) - The wind direction arrow now points in the direction the wind is flowing, not into the wind (#3019) - Fix precipitation css styles and rounding value - Fix wrong vertical alignment of calendar title column when wrapEvents is true (#3053) - Fix empty news feed stopping the reload forever - Fix e2e tests (failed after async changes) by running calendar and newsfeed tests last - Lint: Use template literals instead of string concatenation - Fix default alert module to render HTML for title and message - Fix Open-Meteo wind speed units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If using the
showWindDirectionAsArrow-setting, the arrow points at where the wind is blowing from. I feel it is more appropriate to point it in the direction of the wind. This is how wind arrows usually work in weather forecasts.The text was updated successfully, but these errors were encountered: