From 81c078dc209b319c6f86cc17f03962e394eba8cb Mon Sep 17 00:00:00 2001 From: Ross Younger Date: Wed, 17 Jan 2024 14:53:05 +1300 Subject: [PATCH 1/2] [newsfeed] Fix bug where the newsfeed sometimes stops This bug was introduced by dadc7ba0a26e81adfe6e115a021d922d50b19d41 --- modules/default/newsfeed/newsfeed.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/newsfeed/newsfeed.js b/modules/default/newsfeed/newsfeed.js index 2ecd2ad645..329c04bb33 100644 --- a/modules/default/newsfeed/newsfeed.js +++ b/modules/default/newsfeed/newsfeed.js @@ -335,7 +335,7 @@ Module.register("newsfeed", { * * (N.B. We set activeItemCount and activeItemHash in getTemplateData().) */ - if (this.newsItems.length !== this.activeItemCount || this.activeItemHash !== this.newsItems[0]?.hash) { + if (this.newsItems.length > 1 || this.newsItems.length !== this.activeItemCount || this.activeItemHash !== this.newsItems[0]?.hash) { this.activeItem++; // this is OK if newsItems.Length==1; getTemplateData will wrap it around this.updateDom(this.config.animationSpeed); } From 7f53de949f3254cbcc7a59295841b0bb6eb0aff0 Mon Sep 17 00:00:00 2001 From: Ross Younger Date: Thu, 18 Jan 2024 09:12:33 +1300 Subject: [PATCH 2/2] Update changelog with PR# --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c3268b7eb..099cb7c88d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,7 @@ _This release is scheduled to be released on 2024-04-01._ - [newsfeed] Suppress unsightly animation cases when there are 0 or 1 active news items (#3336) - [newsfeed] Always compute the feed item URL using the same helper function (#3336) - Ignore all custom css files (#3359) +- [newsfeed] Fix newsfeed stall issue introduced by #3336 (#3361) ### Deleted