Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The autoupdate does not auto open Neuron after install the new version on windows. #397

Open
yanguoyu opened this issue Jun 3, 2024 · 2 comments
Open

The autoupdate does not auto open Neuron after install the new version on windows. #397

yanguoyu opened this issue Jun 3, 2024 · 2 comments
Assignees
@silySuper
Labels
bug Something isn't working

Comments

@yanguoyu
Copy link

yanguoyu commented Jun 3, 2024

From https://discord.com/channels/956765352514183188/993224452491984916/1245251438192627714
@yanguoyu yanguoyu added the bug Something isn't working label Jun 3, 2024
@github-actions github-actions bot mentioned this issue Jun 7, 2024
Merged
@yanguoyu yanguoyu self-assigned this Jun 14, 2024
@Danie0918 Danie0918 removed their assignment Jun 17, 2024
@yanguoyu
Copy link
Author

yanguoyu commented Jun 21, 2024 •
edited
Loading

I guess we should modify the button text to "Install Now". For auto open app, the API should set isSlient to true.
https://github.com/electron-userland/electron-builder/blob/14942b70a5da79a5e36e330f64de66ec501b4ac6/packages/electron-updater/src/AppUpdater.ts#L552

But when setting isSilent to false, this silent installation may take some time, giving the impression that the program is unresponsive.

@Danie0918

@yanguoyu yanguoyu mentioned this issue Jun 21, 2024
Merged
@yanguoyu
Copy link
Author

nervosnetwork/neuron#3196

@github-actions github-actions bot mentioned this issue Jun 21, 2024
Merged
@Danie0918 Danie0918 assigned silySuper and unassigned yanguoyu Jun 25, 2024
@github-actions github-actions bot mentioned this issue Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silySuper silySuper

Labels
bug Something isn't working
Projects
Neuron
Status: 🚩Pre Release
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yanguoyu @silySuper @Danie0918