Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextBoxHelper.ButtonClicked should pass ButtonCommandParameter to ButtonCommand.CanExecute #2354

Closed
xmedeko opened this issue Feb 16, 2016 · 3 comments
Closed

TextBoxHelper.ButtonClicked should pass ButtonCommandParameter to ButtonCommand.CanExecute #2354

xmedeko opened this issue Feb 16, 2016 · 3 comments
Assignees
@punker76
Milestone
1.3.0

Comments

@xmedeko
Copy link

xmedeko commented Feb 16, 2016

TextBoxHelper.ButtonClicked call ButtonCommand.Execute and ButtonCommand.CanExecute with different parameters. If should use same parameter for both of them. I.e.

command.CanExecute(commandParameter)
@punker76
Copy link
Member

@xmedeko you're right, i'll change this

@punker76 punker76 added this to the 1.3.0 milestone Feb 16, 2016
@punker76 punker76 self-assigned this Feb 16, 2016
@punker76
Copy link
Member

@xmedeko done with 9672a56

@xmedeko
Copy link
Author

xmedeko commented Feb 16, 2016

Wow, fixed in 7 minutes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@punker76 @xmedeko