Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make camera zoom consistent #3776

Closed
ChristianHuehn opened this issue Oct 8, 2024 · 2 comments · Fixed by #3815 or #3832
Closed

Make camera zoom consistent #3776

ChristianHuehn opened this issue Oct 8, 2024 · 2 comments · Fixed by #3815 or #3832
Assignees
@IhsenBouallegue
Labels
feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@ChristianHuehn
Copy link
Collaborator

ChristianHuehn commented Oct 8, 2024 •
edited
Loading

Feature request

Description

As a user, I want a consistent way of zooming in and out so that I'm able to navigate around the map

Acceptance criteria

  • No modifier is hold
    • Camera zoom-in on mouse
    • Camera zoom-out on mouse
  • Modifier is hold (Shift)
    • Camera zooms like zooming-in under the view cube (top right)
    • Camera zooms like zooming-out under the view cube (top right)

Assumptions & Exclusions

Right now zooming in is working on the mouse and out is done via the cube functionality
@ChristianHuehn ChristianHuehn added feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO labels Oct 8, 2024
@ChristianHuehn ChristianHuehn mentioned this issue Oct 8, 2024
Closed
@CodeCharta CodeCharta added priority:high Set by PO and removed priority:medium Set by PO labels Oct 17, 2024
@ChristianHuehn ChristianHuehn mentioned this issue Oct 21, 2024
Closed
@IhsenBouallegue
Copy link
Collaborator

  • Control is already used to increase the speed. We can either override it or simply use something else. I tests with shift and it woks.
  • if I understood correctly. Zoom to cursor as the new default. Zoom to the middle of the screen (threejs's default) only when pressing a modifier key?

@IhsenBouallegue IhsenBouallegue self-assigned this Nov 5, 2024
@ChristianHuehn
Copy link
Collaborator Author

👍 Shift is fine for me

@IhsenBouallegue IhsenBouallegue mentioned this issue Nov 5, 2024
Merged
6 tasks
phanlezz added a commit that referenced this issue Nov 8, 2024
@phanlezz
feat(visualization): add changelog entry (#3776)
ef485b5
phanlezz added a commit that referenced this issue Nov 8, 2024
@phanlezz
feat(visualization): add changelog entry (#3776)
ac0a95a
phanlezz added a commit that referenced this issue Nov 8, 2024
@phanlezz
feat(visualization): add changelog entry (#3776)
3977875
IhsenBouallegue added a commit that referenced this issue Nov 26, 2024
@IhsenBouallegue
fix(visualization): change modifier key to Alt for alternate zoom mode (
a0dd92b 
#3776)
@IhsenBouallegue IhsenBouallegue mentioned this issue Nov 26, 2024
Merged
6 tasks
IhsenBouallegue added a commit that referenced this issue Nov 28, 2024
@IhsenBouallegue @phanlezz
Change camera zoom alternate mode key (#3832)
50fa1da 
* fix(threeMapControls): toggle zoomToCursor on Shift key press

* fix(threeMapControls): toggle zoomToCursor on Shift key press

* feat(visualization): add changelog entry (#3776)

* fix(visualization): change modifier key to Alt for alternate zoom mode (#3776)

* fix(visualization): update changelog to reflect ALT key for center-focused zoom option

---------

Co-authored-by: IhsenBouallegue <IhsenBouallegue@gmail.com>
Co-authored-by: Sebastian Wolf <65733509+phanlezz@users.noreply.github.com>
phanlezz added a commit that referenced this issue Dec 2, 2024
@IhsenBouallegue @phanlezz
Change camera zoom alternate mode key (#3832)
3c593b0 
* fix(threeMapControls): toggle zoomToCursor on Shift key press

* fix(threeMapControls): toggle zoomToCursor on Shift key press

* feat(visualization): add changelog entry (#3776)

* fix(visualization): change modifier key to Alt for alternate zoom mode (#3776)

* fix(visualization): update changelog to reflect ALT key for center-focused zoom option

---------

Co-authored-by: IhsenBouallegue <IhsenBouallegue@gmail.com>
Co-authored-by: Sebastian Wolf <65733509+phanlezz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IhsenBouallegue IhsenBouallegue

Labels
feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
3 participants
@IhsenBouallegue @CodeCharta @ChristianHuehn