Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change camera zoom alternate mode key #3832

Merged
merged 9 commits into from
Nov 28, 2024

Conversation

IhsenBouallegue
Copy link
Collaborator

Change camera zoom alternate mode key

Please read the CONTRIBUTING.md before opening a PR.

Closes: #3776

Description

Descriptive pull request text, answering:

  • What problem/issue are you fixing?
  • What does this PR implement and how?

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@IhsenBouallegue IhsenBouallegue enabled auto-merge (squash) November 28, 2024 10:02
Copy link

sonarcloud bot commented Nov 28, 2024

Copy link

sonarcloud bot commented Nov 28, 2024

@IhsenBouallegue IhsenBouallegue merged commit 50fa1da into main Nov 28, 2024
7 checks passed
@IhsenBouallegue IhsenBouallegue deleted the fix/3776/make-camera-zoom-consistent branch November 28, 2024 10:16
phanlezz added a commit that referenced this pull request Dec 2, 2024
* fix(threeMapControls): toggle zoomToCursor on Shift key press

* fix(threeMapControls): toggle zoomToCursor on Shift key press

* feat(visualization): add changelog entry (#3776)

* fix(visualization): change modifier key to Alt for alternate zoom mode (#3776)

* fix(visualization): update changelog to reflect ALT key for center-focused zoom option

---------

Co-authored-by: IhsenBouallegue <IhsenBouallegue@gmail.com>
Co-authored-by: Sebastian Wolf <65733509+phanlezz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make camera zoom consistent
3 participants