Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test does not get compiled via compiletest-rs #85

Closed
fuine opened this issue Nov 9, 2017 · 2 comments
Closed

Test does not get compiled via compiletest-rs #85

fuine opened this issue Nov 9, 2017 · 2 comments

Comments

@fuine
Copy link

fuine commented Nov 9, 2017

I'm having troubles incorporating compiletest into lazy_static codebase - I have a simple setup but compiletest does not find any warnings/errors:

error: 0 unexpected errors found, 1 expected errors not found
status: exit code: 101

even though if I run the command printed out it works as expected - yields the expected error. Am I doing something wrong, or is it a problem with compiletest?

$ rustc --version
rustc 1.23.0-nightly (02004ef78 2017-11-08)

I can reproduce the same problems by simply running cargo test in the test-project directory of this crate.

@fuine
Copy link
Author

fuine commented Nov 9, 2017

Turns out i had some problems with macro expansion, as it changes line numbers, but I think that overall 0 unexpected errors is quite misleading, as it indicates that the code does not yield any warnings/errors, while in fact it does. Moreover I think that allowing dead_code should be documented somewhere, because I found out about it by accident.

@laumann I will close this issue, but I think you should take above comments under consideration

@fuine fuine closed this as completed Nov 9, 2017
@laumann
Copy link
Collaborator

laumann commented Nov 13, 2017

@fuine Thanks for your report - sorry for not getting back sooner.

What was the macro expansion problem exactly? I'd like to understand it a bit better. There have been some issues with the link_deps() method that was introduced recently and paths with spaces (see #81), maybe it's related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants