Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with nodemailer 0.2.0 #41

Open
pacovell opened this issue Aug 17, 2011 · 8 comments
Open

Fails with nodemailer 0.2.0 #41

pacovell opened this issue Aug 17, 2011 · 8 comments

Comments

@pacovell
Copy link

SMTPClient is removed from nodemailer 0.2.0, causing havoc.

@cojohn
Copy link

cojohn commented Aug 18, 2011

I believe I'm having problems with the recent update too!

TypeError: undefined is not a function
at CALL_NON_FUNCTION_AS_CONSTRUCTOR (native)
at SMTPClientPool.addClient (/Users/chris/node_modules/mailer/lib/node_mailer.js:38:44)
at Object.node_mail as send (/Users/chris/node_modules/mailer/lib/node_mailer.js:100:10)

@aseemk
Copy link

aseemk commented Aug 19, 2011

+1

@gasi and I ran into this too. An easy short-term fix is to tighten the dependency in package.json to require "0.1.x >= 0.1.10" instead of just ">= 0.1.10". This is a best practice anyway w.r.t. semver anyway -- 0.1 to 0.2 means breaking changes.

Thanks in advance for fixing this.

@tcha-tcho
Copy link

+1
I did try to use a old version but "Error: 503 Already authenticated", I gonna try to downgrade all dependecies :(

@aseemk
Copy link

aseemk commented Aug 22, 2011

@tcha-tcho, the way we worked around this was: in your package.json, put your own explicit "nodemailer" dependency for "0.1.x", npm uninstall nodemailer, then re-npm install/link/bundle/whatever your project.

Important: this nodemailer dependency needs to be before your regular "mailer" dependency, so that the 0.1.x version of nodemailer gets installed, and then this project's nodemailer dependency is already met.

Hope that helps.

@tcha-tcho
Copy link

@aseemk hi, humm Im testing versions and don't think seems to be a nodemailer problem... It seems to be a mailer problem....

mailer has nodemailer as dependency? I did fall back the version of mailer to 0.4.x and all works again... even with nodemailer 2.0 activated ... strange

@balupton
Copy link

fix: #43

@andris9
Copy link

andris9 commented Aug 23, 2011

I'm the author of nodemailer. With 0.2.0 there was a change that introduced ability to use different backends for sending mail besides SMTP (like Amazon SES etc) and thus SMTPClient was hidden under a engine selection layer. I'm not very familiar with node_mailer and how it actually uses nodemailer so I wasn't able to foresee the impact to it from the change. Sorry for that.

@aseemk
Copy link

aseemk commented Oct 15, 2011

[deleted] Oops, meant to comment this on the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants