Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups of release PRs #1029

Open
1 task
MarcoIeni opened this issue Oct 7, 2023 · 4 comments
Open
1 task

Support groups of release PRs #1029

MarcoIeni opened this issue Oct 7, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MarcoIeni
Copy link
Owner

MarcoIeni commented Oct 7, 2023

Motivations

While I prefer "release on every PR", I'm unsure if that will work with all of the libraries we are dealing with and we'd likely need to be able to release subsets as needed.

From #1019 (comment)

Solution

We could have a pr-group config in the configuration file, so that release-plz opens 1 PR for each group of packages. Dependent packages, even if not specified in the configuration, should be included in the pr as well.
This is similar to the grouped update feature of dependabot.

Notes

@MarcoIeni MarcoIeni added the enhancement New feature or request label Oct 7, 2023
@jbr
Copy link

jbr commented Jan 2, 2024

Would this also include a "one release PR for each workspace crate" or is that a distinct use case?

@MarcoIeni
Copy link
Owner Author

I guess you can define one group for each crate :)
Having one PR for each crate, seems like a use case that could be enabled by this feature. But release-plz automatically figures out the groups, instead having the user to specify them.

@epage
Copy link

epage commented Oct 4, 2024

This is proposing a static subset. The problem is that it isn't always static.

@MarcoIeni
Copy link
Owner Author

MarcoIeni commented Oct 4, 2024

Feel free to write how you would implement this 👍

EDIT: do you want to specify which packages to update when creating the release pr? E.g. from the cli?

@MarcoIeni MarcoIeni added the help wanted Extra attention is needed label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants