-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare release only if at least one commit respects a certain regex #1274
Comments
hi! can you help please with fast(yes/no) answer? is it a good place to match commits?
or, in this loop, but higher? |
I think that should be a good place, yes. Anyway I think it's a good place to start :) Are you working on a pr? 🤩 |
Im not sure i will be able to finalize PR but i've tried to poke around. Feel free to use it if it makes sense #1278. Currently i'm feeling lack of automated tests. And i haven't tested it manually, must study documentation to understand how to do it properly. However existing tests passed successfully except
Perhaps im doing smtn wrong. Didn't have enough time to figure it out. Would be glad to know if i moved in right direction 🕵️ |
To make schema_is_up_to_date test pass, just run
I have done it for you 👍 for the other tests, you need to run docker as explained here. 👍 |
I looked at the PR, looks good. I need to test it. |
Thank you! 👍 I will try to write an integration test 🙊 |
@MarcoIeni i have an idea how to save time on responding to inattentive contributors 😄 , please take a look #1285 |
I added a small integration test myself because I wanted to merge this today. Thanks for your contribution ❤️ |
Motivations
It might be too noisy to raise PRs on every commit.
E.g. some people might not want to release the crate if the commits contain only
chore
s.Solution
We should have a
release_commits
field in the workspace section of the configuration.In
release-plz update
andrelease-plz release-pr
we should bump the version and update the changelog of the crate only if at least one of the commits matches that regex.E.g., if I want to only release when there's a new feature I write `release_commits = "^feat:" in the config.
Please update the doc too.
Additional context
Requested here.
The text was updated successfully, but these errors were encountered: