Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the flag --project-manifest to --manifest-path #1333

Closed
2 tasks done
MarcoIeni opened this issue Mar 10, 2024 · 3 comments · Fixed by #1395
Closed
2 tasks done

Change the flag --project-manifest to --manifest-path #1333

MarcoIeni opened this issue Mar 10, 2024 · 3 comments · Fixed by #1395
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MarcoIeni
Copy link
Owner

MarcoIeni commented Mar 10, 2024

This is because the --manifest-path flag also exists in cargo.

Keep the old flag for cli retro-compatibility, but hide it from the help menu.

  • also update the github action input parameter
  • also update any occurrence of --project-manifest in the codebase (e.g. in error messages)
@MarcoIeni MarcoIeni added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 10, 2024
@MarcoIeni MarcoIeni added this to the release-plz-v0.4 milestone Mar 24, 2024
@amartyadav
Copy link
Contributor

amartyadav commented Apr 8, 2024

Hi @MarcoIeni, I would like to implement this, and I have started working on it.

I have a questions to clarify -

  • I am assuming you do not want any refactoring of functions to follow the --manifest-path name, right? for eg.
    fn optional_project_manifest(&self) -> Option<&Utf8Path> should remain the same and not be changed to
    fn optional_manifest_path(&self) -> Option<&Utf8Path> . Am I correct to assume this?

@amartyadav
Copy link
Contributor

Addressed this issue in PR #1390. @MarcoIeni , please have a look whenever you can. Cheers! 😇

@MarcoIeni
Copy link
Owner Author

MarcoIeni commented Apr 9, 2024

Am I correct to assume this?

I don't think it's needed to refactor the functions, yes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants