Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dispose the HttpClient #79

Open
MarcusOtter opened this issue Jul 1, 2021 · 0 comments
Open

Don't dispose the HttpClient #79

MarcusOtter opened this issue Jul 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@MarcusOtter
Copy link
Owner

Is your feature request related to a problem? Please describe.
It's weird how the apod client will dispose of the HttpClient you give it when the apod client is disposed. In practice it means you shouldn't call dispose on the apodclient if you want to reuse the HttpClient.

Describe the feature you'd like
Don't default to creating an HttpClient, take it as a required parameter and make it non-disposable. Caller does the disposing.

@MarcusOtter MarcusOtter added the enhancement New feature or request label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant