diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index fbba6e12f12ab..c97f9827e5969 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,61 +1,47 @@ -- [x] *The Jira issue number for this PR is: MDEV-_____* +- [x] *The Jira issue number for this PR is: MDEV-______* ## Description TODO: fill description here ## How can this PR be tested? -TODO: modify the automated test suite to verify that the PR causes MariaDB to -behave as intended. Consult the documentation on -["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server). -In many cases, this will be as simple as modifying one `.test` and one `.result` -file in the `mysql-test/` subdirectory. Without _automated_ tests, future regressions -in the expected behavior can't be automatically detected and verified. +TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended. +Consult the documentation on ["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server). + -If the changes are not amenable to automated testing, please explain why not and -carefully describe how to test manually. +If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually. ## Basing the PR against the correct MariaDB version -- [ ] *This is a new feature and the PR is based against the latest MariaDB development branch* -- [ ] *This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced* +- [ ] *This is a new feature and the PR is based against the latest MariaDB development branch.* +- [ ] *This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.* -## Backward compatibility -TODO: fill details here, if applicable, or remove the section - ## PR quality check - [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/11.0/CODING_STANDARDS.md) file and my PR conforms to this where appropriate. +- [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.