Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings for highlight.js v10.7 #1518

Closed
raysonkoh opened this issue Mar 22, 2021 · 0 comments · Fixed by #1521
Closed

Fix deprecation warnings for highlight.js v10.7 #1518

raysonkoh opened this issue Mar 22, 2021 · 0 comments · Fixed by #1521

Comments

@raysonkoh
Copy link
Contributor

raysonkoh commented Mar 22, 2021

While serving a markbind site using markbind serve, I noticed in the outputs there are quite a lot of warnings relating to deprecation warning specifically for the highlight(lang, code, ...args) method of highlight.js. Ref: highlightjs/highlight.js#2277

image

This might be quite annoying for the users, as showing more than one instance of the deprecation warning may not be useful and the user shouldn't be seeing such deprecation warnings as it is more relevant for the devs. Should we refactor the highlight method in our code to follow the new standard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants