On-Premises IFD configuration constructs invalid URL by appending /ORG

[janis-veinbergs]

When connected via XTB to On-Premises instance via IFD URL, open record constructs invalid URL - it appends organization name but it should not.

Looks like ConnectionDetails has UseIfd property available.

Other properties could also be used: UseOnline which already checks if connecting to .dynamics.com

I suspect UseIfd will be false anyway for oauth - maybe it could just check if for onprem instances /organization is equals to domain first part, then strip org. Dunno if there could be any consequences.

Sql4Cds/MarkMpn.Sql4Cds.XTB/ConnectionExtensions.cs

Lines 17 to 37 in 339cd16

	public static string GetFullWebApplicationUrl(this ConnectionDetail connectiondetail)
	{
	var url = connectiondetail.WebApplicationUrl;
	if (string.IsNullOrEmpty(url))
	{
	url = connectiondetail.ServerName;
	}
	if (!url.ToLower().StartsWith("http"))
	{
	url = string.Concat("http://", url);
	}
	var uri = new Uri(url);
	if (!uri.Host.EndsWith(".dynamics.com"))
	{
	if (string.IsNullOrEmpty(uri.AbsolutePath.Trim('/')))
	{
	uri = new Uri(uri, connectiondetail.Organization);
	}
	}
	return uri.ToString();
	}

Perhaps replacing

!uri.Host.EndsWith(".dynamics.com")

with

!connectiondetail.UseIfd && !connectiondetail.UseOnline

Would be a good improvement.