Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOZZLE_AS_PROBE ABL regression #16410

Closed
pmjdebruijn opened this issue Jan 1, 2020 · 4 comments
Closed

NOZZLE_AS_PROBE ABL regression #16410

pmjdebruijn opened this issue Jan 1, 2020 · 4 comments

Comments

@pmjdebruijn
Copy link
Contributor

pmjdebruijn commented Jan 1, 2020

The following commit ( in Marlin 2.0.1 and bugfix-2.0.x ) causes a regression with ABL (bilinear):

1c9ccce (#15929)

Relevant configuration:

#define BLTOUCH
#define AUTO_BED_LEVELING_BILINEAR
#define GRID_MAX_POINTS_X 3
#define NOZZLE_TO_PROBE_OFFSET { -44, -6, 0 }
#define MIN_PROBE_EDGE 44
#define EXTRAPOLATE_BEYOND_GRID

I have this specifically on an Ender 3 Pro with the SKR mini E3 board.

With that commit applied, my 9 point grid is clustered absurdly closely to each other in the center of the board, almost as-if MIN_PROBE_EDGE had been set to 80 or something along those lines.

Reverting 1c9ccce on 2.0.1 returns behavior to normal, so that definitively confirms 1c9ccce is causing this issue.

And on a sidenote shouldn't MIN_PROBE_EDGE default to max(abs(NOZZLE_TO_PROBE_OFFSET[X]),abs(NOZZLE_TO_PROBE_OFFSET[Y]))

@pmjdebruijn pmjdebruijn changed the title 1c9ccce5 abl regression NOZZLE_AS_PROBE ABL regression Jan 1, 2020
@sjasonsmith
Copy link
Contributor

This is a duplicate of #16348. PR #16367 fixes it. You can use the changes from that PR until it is merged.

@pmjdebruijn
Copy link
Contributor Author

Apologies for filing a duplicate. For the time being I'm just reverting that commit. I'll keep an eye out for when that branch will be merged.

@boelle
Copy link
Contributor

boelle commented Jan 1, 2020

closing since its a dublicate

@boelle boelle closed this as completed Jan 1, 2020
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants