Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G35 Outputs long string then hangs firmware #19473

Closed
RealDeuce opened this issue Sep 22, 2020 · 5 comments
Closed

G35 Outputs long string then hangs firmware #19473

RealDeuce opened this issue Sep 22, 2020 · 5 comments
Labels
A: ATmega2560 Bug: Confirmed ! Fix Included A fix is included in the description

Comments

@RealDeuce
Copy link

RealDeuce commented Sep 22, 2020

Bug Description

The tramming_point_name[] array is PROGMEM and points to PGMSTR() strings... this apparently means it can't be used with SERIAL_ECHOPAIR() on Arduino.

On my CR-10 v3 with original Creality board, the first output sent a long string of characters to the serial port and then hung.

My Configurations

MyConfig.zip

Steps to Reproduce

  1. Build for original Creality board with ASSISTED_TRAMMING
  2. Execute G35 command over serial port.

Expected behavior:

Instructions for tramming are printed

Actual behavior:

The first tramming point name is printed as a very long sequence of letters followed by the instructions after which the firmware hangs and a reboot is required.

Additional Information

Fixed for me with this commit, but the pull request requirements are too onerous for me to be arsed. I know the patch isn't sufficient as-is, but I'm too busy to follow it through properly.

Basically, I just use serialprintPGM((char *)pgm_read_ptr(&tramming_point_name[i])); for the names and it works for me now.

@sjasonsmith sjasonsmith added the Needs: Patch A patch is needed to fix this label Sep 23, 2020
@sjasonsmith sjasonsmith added Bug: Confirmed ! Fix Included A fix is included in the description and removed Needs: Patch A patch is needed to fix this labels Oct 10, 2020
@sjasonsmith
Copy link
Contributor

@Speaka reported the same issue in #19896 and verified that the included fix in this Bug report worked.
They also volunteered to prepare a PR for it, so hopefully we will see that show up in the next several days.

@Speaka
Copy link
Contributor

Speaka commented Oct 27, 2020

Please test with this PR.

@sjasonsmith
Copy link
Contributor

Thanks for stepping up and filing the PR @Speaka!

@RealDeuce
Copy link
Author

Works for me, thanks a lot @Speaka!

@github-actions
Copy link

github-actions bot commented Jan 3, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: ATmega2560 Bug: Confirmed ! Fix Included A fix is included in the description
Projects
None yet
Development

No branches or pull requests

3 participants