Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Color UI: improve numeric editors, adding more buttons, enable cancel #26230

Closed
vlsi opened this issue Sep 4, 2023 · 2 comments
Closed
Labels
C: LCD & Controllers T: Feature Request Features requested by users.

Comments

@vlsi
Copy link
Contributor

vlsi commented Sep 4, 2023

Is your feature request related to a problem? Please describe.

It looks like the current editors for "probe offset", "drive current", "preheat temperature" are hard to use.
In my MKS_ROBIN_TFT35 (480x320, 3.5") the editors are just a "volume control" with two buttons "plus, minus, ok".

Suppose the drive current is "800ma". How could I alter it to 400? "minus" button would require many clicks (e.g. 40 if each reduces 10ma), and the volume controller does not help much as it is inaccurate.

Are you looking for hardware support?

No response

Describe the feature you want

I suggest the following UI:

E0 current, ma, 
   [ ^ ] [ ^ ] [ ^ ]
     8     0     0
   [ v ] [ v ] [ v ]

[ ] apply immediately
[apply] [cancel]
Probe Z offset, mm
   [ ^ ]   [ ^ ] [ ^ ]
 -   0   .   9     3
   [ v ]   [ v ] [ v ]

[ ] apply immediately
[apply] [cancel]
Fan speed, %
   [ ^ ] [ ^ ] [ ^ ]
           7     0
   [ v ] [ v ] [ v ]

[ ] apply immediately
[apply] [cancel]

In other words:

  1. For each decimal place, there could be a button to increase/decrease. The button would be big enough so one could perform fine-tuning while watching the print
  2. There could be "apply immediately" checkbox, so values like "fan speed" could be adjusted on the fly without forcing the user to click "ok" to apply the setting
  3. There should be "cancel" button so the edit could be discarded if it is not wanted

Additional context

No response

@vlsi vlsi added the T: Feature Request Features requested by users. label Sep 4, 2023
@thisiskeithb
Copy link
Member

This is being worked on:

Copy link

github-actions bot commented Nov 4, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: LCD & Controllers T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

2 participants