Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 'Incorrect type. Expected "array".' w/ "✅ Label bug reports" #26489

Closed
1 task done
classicrocker883 opened this issue Dec 1, 2023 · 5 comments · Fixed by #26490
Closed
1 task done

[BUG] 'Incorrect type. Expected "array".' w/ "✅ Label bug reports" #26489

classicrocker883 opened this issue Dec 1, 2023 · 5 comments · Fixed by #26490

Comments

@classicrocker883
Copy link
Contributor

classicrocker883 commented Dec 1, 2023

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

even though it seems to work fine how it is, I do receive an error/warning (red squiggles) with ISSUE_TEMPLATE/bug_report.yml.

name: 🪲 Report a bug
description: Create a bug report to help improve Marlin Firmware
title: "[BUG] (bug summary)"
labels: 'Bug: Potential ?'
body:
  - type: markdown

specfically this line labels: 'Bug: Potential ?'
it says 'Incorrect type. Expected "array".' then gives a link for the correct syntax.

based on other examples, the corrected code should be

labels: ["Bug: Potential ?"]

it does help if you ever wanted to include other labels.

Bug Timeline

11/29 - ✅ Label bug reports

Expected behavior

should not have an error

Actual behavior

error in form of red squiggles

Steps to Reproduce

No response

Version of Marlin Firmware

current bugfix

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@thisiskeithb
Copy link
Member

thisiskeithb commented Dec 1, 2023

This works fine, but please submit a PR if you'd like to see this changed.

We also don't have brackets for Feature Request tags:

labels: 'T: Feature Request'

@classicrocker883
Copy link
Contributor Author

This works fine, but please submit a PR if you'd like to see this changed.

yes it does seem to "work", but do you still see the error squiggles within VScode?

@thisiskeithb
Copy link
Member

yes it does seem to "work", but do you still see the error squiggles within VScode?

No.

@thisiskeithb
Copy link
Member

I don't think brackets are required for a single label. Especially since it works fine without them.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants