Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fast / erratic homing moves #27354

Closed
1 task done
rq3 opened this issue Aug 16, 2024 · 10 comments
Closed
1 task done

[BUG] Fast / erratic homing moves #27354

rq3 opened this issue Aug 16, 2024 · 10 comments

Comments

@rq3
Copy link

rq3 commented Aug 16, 2024

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

The bugfix as of August 16, 2024 fails to home during a G33 delta calibration. After the last probe point, when it should gracefully home and then start the next iteration, it randomly moves at high speed in any axis.

Bug Timeline

new

Expected behavior

I expect it to complete G33.

Actual behavior

It randomly moves at high speed on a random axis when it should be homing after a G33 iteration.

Steps to Reproduce

  1. Compile and install latest bugfix
  2. Start G33 delta calibration
  3. After probing, observe effector wildly head in random directions at high speed, when it should just quietly home.

Version of Marlin Firmware

latest bugfix (Aug. 16, 2024)

Printer model

Anycubic Predator

Electronics

Stock Trigorilla Pro (STM32F103ZETA)

LCD/Controller

Anycubic TFT 3.5

Other add-ons

none

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

config.zip

@thinkyhead
Copy link
Member

Would you be able to test some bugfix-2.1.x commits to narrow this down?

The strategy is to find a commit from some point in the "distant" past where the feature works. Then, test a commit from halfway between that date and today…. And then you keep going to the commit half-way in between your "known to work" commit and your "known to be broken" commit until you find the exact day where it broke.

If you started from a point 256 commits in the past, it would take no more than 8 tests to find the exact commit that broke it.

@renzaaa
Copy link

renzaaa commented Aug 18, 2024

G33 delta calibration works on 2024-07-27 bugfix.

@rq3
Copy link
Author

rq3 commented Aug 18, 2024

Also fails in bugfix 89b0143 from Aug.11.
Here's a brief video of the effector smoothly probing points 15 and 16 during G33, and then going nuts trying to home for the next iteration:

IMG_2056.MOV

@thisiskeithb
Copy link
Member

thisiskeithb commented Aug 18, 2024

Thanks for tracking it down!

Fails in bugfix 89b0143 from Aug.11.

It actually worked in our favor since you found the exact commit, but there must have been a GitHub glitch since all the commits from #27346 were merged intobugfix-2.1.x individually instead of the "Squash and merge"/single commit (with the referenced PR # in the title) that's usually done.

@rq3
Copy link
Author

rq3 commented Aug 18, 2024

Thanks for tracking it down!

Fails in bugfix 89b0143 from Aug.11.

It actually worked in our favor since you found the exact commit, but there must have been a GitHub glitch since all the commits from #27346 were merged intobugfix-2.1.x individually instead of the usual "Squash and merge"/single commit (with the referenced PR # in the title) that's usually done.

My apologies, @thisiskeithb. My last post was badly worded, as it implies that the failure is in 89b0143. I should have said that it "also fails in 89b0143". I have not checked prior to that, as I am having trouble locating the full commits. However, we do know that it was good on July 27, and bad on August 11.

@thisiskeithb
Copy link
Member

thisiskeithb commented Aug 21, 2024

I am having trouble locating the full commits.

You can always find all commits by clicking on the "Commits" section from the main repo page:

image

This will lead you to the full commit history where you can browse the code from any point in time:

image

I have not checked prior to that

So close! 89b0143 is likely the source of issues for you since it causes a really fast X/Y travel move to Z_SAFE_HOMING_X_POINT/Z_SAFE_HOMING_Y_POINT during G28 for non-Delta configs.

Resetting to right before that commit (i.e. 0790a9d) will likely fix the reported issue, so give it a try: .ZIP link

Here's a .ZIP link of compatible Configurations if you don't want to back port your config. Note: You'll need to remove the two "#error" lines at the top of Configuration.h if you use these configs since they originate from the import-2.1.x branch.

@rq3
Copy link
Author

rq3 commented Aug 21, 2024

Bingo. 0790a9d works. The next commit, 89b0143, does not. Just as you suspected, @thisiskeithb.

@thisiskeithb thisiskeithb changed the title [BUG] Latest bugfix won't home during G33 delta calibration [BUG] Fast / erratic homing moves Aug 22, 2024
@thisiskeithb
Copy link
Member

thisiskeithb commented Aug 24, 2024

@rq3: Can you try thinkyhead’s suggestion? #27349 (comment)

Edit: thinkyhead snuck e2d8b2f in, so grab the latest bugfix and give it a test. This fixes the super fast x/y homing move on my i3 machines.

@rq3
Copy link
Author

rq3 commented Aug 24, 2024

@rq3: Can you try thinkyhead’s suggestion? #27349 (comment)

Edit: thinkyhead snuck e2d8b2f in, so grab the latest bugfix and give it a test. This fixes the super fast x/y homing move on my i3 machines.

I'm on it. Will report back soon.

@rq3
Copy link
Author

rq3 commented Aug 24, 2024

Latest bugfix works perfectly! Thanks guys! Issue closed.

IMG_2058

IMG_2057.MOV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants