Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make options camelCase? #9

Closed
poperigby opened this issue Jul 11, 2024 · 2 comments
Closed

Make options camelCase? #9

poperigby opened this issue Jul 11, 2024 · 2 comments

Comments

@poperigby
Copy link

This is a silly little nitpick, but maybe the options should be camelCase to match NixPkgs.vpnConfinement instead of vpnconfinement, vpnNamespace instead of vpnnamespace, etc.
@Maroka-chan
Copy link
Owner

Not silly at all :) They should of course be consistent with the other options.
They have been renamed in 07b5600

A warning is only thrown for vpnnamespaces, but the other options have been renamed as well.
mkRenamedOptionModule does not throw warnings when defined in a submodule for some reason. It might be related to this issue.

@poperigby
Copy link
Author

Thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@poperigby @Maroka-chan