Make SIM119 not trigger on complex operations in the constructor, and when async methods are present on a class. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when async methods are present on a class.
MartinThoma
reviewed
Dec 12, 2021
MartinThoma
reviewed
Dec 12, 2021
MartinThoma
reviewed
Dec 12, 2021
|
@dsegan Thank you very much for the PR! Looks good - I just have some minor changes to keep the maximum line length. |
MartinThoma
reviewed
Dec 12, 2021
|
@MartinThoma Thanks a bunch for the quick review, and my apologies for the line length omissions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #63.