Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP spec violation: returning signature label offsets when the client hasn't signaled support #446

Closed
thomasjm opened this issue Jul 21, 2019 · 1 comment
Closed

LSP spec violation: returning signature label offsets when the client hasn't signaled support #446

thomasjm opened this issue Jul 21, 2019 · 1 comment

Comments

@thomasjm
Copy link

This is the exact same situation as issue #438 . In this case, ccls is returning signature label offsets even though the client hasn't set signatureHelp.signatureInformation.parameterInformation.labelOffsetSupport in their client capabilities.

I'm filing this one as its own issue in case you want to handle it separately. This is a more recent LSP feature than the previous issue, part of 3.14.0 from mid-December 2018.
@MaskRay
Copy link
Owner

MaskRay commented Jul 21, 2019

This is one which I am very unhappy with:( (Both the initial proposal, and the amended spec) It was pretty much a mistake to make it

label: string; at first then change it to

label: string | [number, number]; afterwards.

See microsoft/language-server-protocol#640

@MaskRay MaskRay closed this as completed Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaskRay @thomasjm