Replies: 1 comment 1 reply
-
It's funny you mention AppAttest, before Apple released any official documentation on their I want to sleep on it, about what you're proposing. Regarding exposing the various helpers: on its face it seems fine, but the orchestration of the various internal helper functions into something like the verification functionality you demonstrate above would never make it into SimpleWebAuthn as a "simple" way to perform this verification. It would need to be cobbled together and maintained by developers like you in whatever project you want to add this to. Which makes me wonder if the helpers couldn't be pulled out into a separate "@simplewebauthn/server-helpers" package. As a separate package there'd be more opportunities to incorporate that logic into various other verification libraries that could exist independent of @simplewebauthn/server while benefiting from its typed logic. But now we're talking a separate package namespace because "@simplewebauthn/appleAppAttest" has nothing to do with WebAuthn! One thing I have almost no objections to is your proposal to "support parameterization of the apple root certificate". There are a small number of root certificates that are currently baked into the library (not just Apple-related) that really should be default values that can then be overridden by environment variables. If you are looking to contribute again that would be a great slam dunk of an addition to the library. These are my initial thoughts. AppAttest, while similar to the "apple" WebAuthn attestation format, falls outside the scope no matter how I try to picture it...let me sleep on it for a day or two and maybe a solution will come to mind. |
Beta Was this translation helpful? Give feedback.
-
👋 Hi @MasterKale, I've been working on a project that uses Apple App Attest, which is based on WebAuthn, but requires some nuanced checks which I don't think are compatible with the high level interface currently exposed in
@simplewebauthn/server
package.My initial thoughts on what I might want are:
I worked up an example using
@simplewebauthn/server
to illustrate how easily Apple App Attest can be implemented using the the helpers that are already defined in the package:TIA for taking a look and giving feedback. I'm happy to open PRs for any changes we agree on. 🙏
Beta Was this translation helpful? Give feedback.
All reactions