Skip to content
This repository has been archived by the owner on Jan 30, 2019. It is now read-only.

Signing issues? #2

Open
IzzySoft opened this issue Jun 18, 2018 · 9 comments
Open

Signing issues? #2

IzzySoft opened this issue Jun 18, 2018 · 9 comments

Comments

@IzzySoft
Copy link

With the latest APK from releases/ I get:

ERROR: No signing certificates found in v1.5.2.apk
WARNING: Skipping 'v1.5.2.apk' with invalid signature!

Did you incidentally not sign it, or just forgot to? In the latter case: could you please do sign the releases?

@MathieuAndrade
Copy link
Owner

MathieuAndrade commented Jun 18, 2018

My bad ! The apk has been signed but i forgot to specify that the certificate has changed, uninstall the old version ;)
I will update the readme ! Thanks !

@IzzySoft
Copy link
Author

Thanks for the fast response! But I didn't even have the previous version. The latest one doesn't seem to be signed at all (that error is thrown when I try to integrate the APK with my F-Droid repo).

@MathieuAndrade
Copy link
Owner

🤔 The apk has been signed however.
I do not know F-Droid and how it works but if you can test with this apk plz

@IzzySoft
Copy link
Author

Thanks! That one throws a lot of warnings, but no error anymore:

WARNING: META-INF/android.arch.core_runtime.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/android.arch.lifecycle_livedata-core.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/android.arch.lifecycle_runtime.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/android.arch.lifecycle_viewmodel.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_animated-vector-drawable.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_appcompat-v7.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_cardview-v7.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_design.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_gridlayout-v7.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_recyclerview-v7.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-compat.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-core-ui.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-core-utils.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-fragment.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-media-compat.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-v13.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-v4.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_support-vector-drawable.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.
WARNING: META-INF/com.android.support_transition.version not protected by signature. Unauthorized modifications to this JAR entry will not be detected. Delete or move the entry outside of META-INF/.

to get rid of those warnings you could probably just remove those files on build. I vaguely remember there was some gradle setting even.

Btw: What license is the app using?

@MathieuAndrade
Copy link
Owner

MathieuAndrade commented Jun 19, 2018

Gooood ! I will investigate these warnings ! It seems that it can be adjusted thanks to that

packagingOptions {
    exclude 'META-INF/LICENSE.txt'
    exclude 'META-INF/LICENSE'
}

Thanks !
At the moment there has no license :)

@IzzySoft
Copy link
Author

I knew there was a way to fix that via gradle. Good you found it!

Are you planning for a license at least? No license is … hm, well, maybe "dangerous" is a too hard word, but that direction. Might attract trouble. And makes some people nervous 😉

PS: Gladys is now available via my repo. Cannot further it to the official F-Droid repo to to the GMS component – but as long as you attach a working .apk to new releases, they should reach my repo within 24h. Makes it easier for folks to keep it up-to-date. Hope that's OK with you?

@MathieuAndrade
Copy link
Owner

I know but I have not yet taken the time to think about the appropriate license!
I will note it in my to-do list

Awesome ! For me it's ok ^^

@IzzySoft
Copy link
Author

Just ping me please if you've decided on the license (so I can update that information in my repo). If you have a flavor without GMS, we could try to get your app into the official repo; feel free to ping me on that then as well.

@MathieuAndrade
Copy link
Owner

No problem !
I'll let you know about the progress !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants