Skip password confirmation when starting polykey

[tegefaulkes]

Describe the bug

I've found it's possible to skip confirming the password when starting Polykey from fresh state. Sending EOF with ctrl + d will seem to just skip confirming the password.

brian@matrix-precision-3480-syzygy:~/workspace/Polykey-CLI/ > npm run polykey -- agent start -np ./tmp/test6

> polykey-cli@0.1.8 polykey
> ts-node src/polykey.ts agent start -np ./tmp/test6

✔ Enter new password … ********
✖ Confirm new password … // `ctrl + d` here to send `EOF`
(node:1198380) [DEP0112] DeprecationWarning: Socket.prototype._handle is deprecated
(Use `node --trace-deprecation ...` to show where the warning was created)
pid             1198380
nodeId          vvjefvesag6d11es3hpkdg8po4osiq8a1luq2gk4e8r1qh95eviv0
clientHost      ::1
clientPort      46261
agentHost       ::
agentPort       60631
recoveryCode    pottery assume scrap upon sad tackle hazard now mother sponsor aunt prison alcohol arm rough rifle clay twice team cool jewel devote letter misery

As you can see we are prompted twice for the password when creating new state. But sending ctrl+d on the 2nd promp allows us to skip it.

To Reproduce

1. Start polykey with polykey agent start with no existing state to create a new node.
2. Enter a password when first prompted
3. Press ctrl+d when prompted to confirm
4. polykey starts without failing.

Expected behavior

It's expected that if we provide the wrong password or no password when confirming the password then starting polykey should fail.

Platform (please complete the following information)

• Device: precision laptop
• OS: nixos
• Version 23

Additional context

Found when looking into the problem with #139

Notify maintainers

@tegefaulkes

[tegefaulkes]

Turned out to be a very minor bug in the prompting logic.