Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Support two finger dismiss swipe #4

Open
MattIPv4 opened this issue May 18, 2018 · 0 comments
Open

Support two finger dismiss swipe #4

MattIPv4 opened this issue May 18, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest An issue open and looking for help as part of hacktoberfest help wanted Extra attention is needed
Milestone
1.0.0

Comments

@MattIPv4
Copy link
Owner

MattIPv4 commented May 18, 2018 •
edited
Loading

Currently the two finger dismiss swipe has no threshold.

A threshold for the two finger swipe should be implemented to reduce accidental dismissal whilst scrolling. This most likely needs to be done through some tracking as the scroll event is called multiple time on mac due to its smooth scrolling.
Further, this needs to be a capturing event to stop accidental navigation away from the current page.
@MattIPv4 MattIPv4 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels May 18, 2018
@MattIPv4 MattIPv4 added hacktoberfest An issue open and looking for help as part of hacktoberfest and removed bug Something isn't working labels Oct 1, 2018
@MattIPv4 MattIPv4 added the good first issue Good for newcomers label May 21, 2019
@MattIPv4 MattIPv4 added this to the 1.0.0 milestone Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest An issue open and looking for help as part of hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@MattIPv4